Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump Snaps dependencies #30396

Merged
merged 10 commits into from
Feb 19, 2025
Merged

chore: Bump Snaps dependencies #30396

merged 10 commits into from
Feb 19, 2025

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Feb 18, 2025 •
edited
Loading

Description

Bump Snaps packages and handle any required changes.

Summary of Snaps changes:

  • Add additional properties to snap_getPreferences
  • Add crossAlignment to Box

Open in GitHub Codespaces

Related issues

Fixes: #30368

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Feb 18, 2025
@socket-security Socket Security
Copy link

socket-security bot commented Feb 18, 2025 •
edited
Loading

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 222 kB metamaskbot
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 50.6 kB metamaskbot
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 499 kB metamaskbot
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] Transitive: network +1 7.04 MB danfinlay, gudahtt, kumavis, ...6 more
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 1.56 MB metamaskbot
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 1.52 MB metamaskbot

View full report↗︎

@metamaskbot
Copy link
Collaborator

Builds ready [47507a7]
Page Load Metrics (1772 ± 90 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29121331711374180
domContentLoaded14822116174618991
load14872130177218890
domInteractive246733115
backgroundConnect107133199
firstReactRender1490402613
getState46215157
initialActions01000
loadScripts10661618125214067
setupStore884202210
uiStartup17342432206220799
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -13.17 KiB (-0.22%)
  • ui: 0 Bytes (0.00%)
  • common: 63.22 KiB (0.68%)

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [58bf239]
Page Load Metrics (1843 ± 91 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34722151765376181
domContentLoaded15112201181118890
load15412216184318991
domInteractive25118432713
backgroundConnect9102342713
firstReactRender1693402613
getState565232211
initialActions01000
loadScripts10271697133417283
setupStore86317188
uiStartup18052481212518689
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -12.5 KiB (-0.21%)
  • ui: 0 Bytes (0.00%)
  • common: 63.22 KiB (0.68%)

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 19, 2025
@FrederikBolding FrederikBolding marked this pull request as ready for review February 19, 2025 09:57
@FrederikBolding FrederikBolding requested review from a team as code owners February 19, 2025 09:57
Mrtenz
Mrtenz previously approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and policy changes look good to me. Haven't tested the changes yet.

@metamaskbot
Copy link
Collaborator

Builds ready [3848e27]
Page Load Metrics (1847 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25921351769374180
domContentLoaded15472074181713766
load15962140184714469
domInteractive269740167
backgroundConnect972342512
firstReactRender1598482713
getState45314136
initialActions01000
loadScripts11211538132912359
setupStore87619199
uiStartup17672686213420498
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -12.5 KiB (-0.21%)
  • ui: 192 Bytes (0.00%)
  • common: 63.22 KiB (0.68%)

GuillaumeRx
GuillaumeRx requested changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@GuillaumeRx GuillaumeRx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error when trying to get preferences

@metamaskbot
Copy link
Collaborator

Builds ready [e7552d8]
Page Load Metrics (1786 ± 116 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25726071627467224
domContentLoaded152025261764233112
load152525901786242116
domInteractive24196554220
backgroundConnect877272010
firstReactRender1483422713
getState56216178
initialActions00000
loadScripts10481906128619192
setupStore76314157
uiStartup175928002051243117
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -12.49 KiB (-0.21%)
  • ui: 209 Bytes (0.00%)
  • common: 63.22 KiB (0.68%)

Mrtenz
Mrtenz previously approved these changes Feb 19, 2025
View reviewed changes
GuillaumeRx
GuillaumeRx previously approved these changes Feb 19, 2025
View reviewed changes
@FrederikBolding FrederikBolding added this pull request to the merge queue Feb 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 19, 2025
FrederikBolding and others added 7 commits February 19, 2025 15:14
@FrederikBolding
chore: Bump Snaps dependencies
dd32aee
@FrederikBolding
Update LavaMoat policies
4f4cfe3
@hmalik88 @FrederikBolding
feat: update snap_getPreferences (#30290)
55f5bcd 
## **Description**

Updated the `getPreferences` method with additional preferences that
protocol snaps will need.

## **Related issues**

Fixes: MetaMask/snaps#3076

## **Manual testing steps**

1. Build off of this branch.
2. Clone https://github.com/hmalik88/swiss-knife-snap and run `yarn
start`.
3. Click the get preferences button and observe in the console the
object with the newly added properties.

## **Screenshots/Recordings**

### **After**


https://github.com/user-attachments/assets/d12d6dd6-cbbe-4b08-a966-59c91abe00d1

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@FrederikBolding
Fix lint
633d44d
@FrederikBolding
Fix lint
3a9687c
@GuillaumeRx @FrederikBolding
feat(snaps): Add crossAlignment to Box (#30400)
981b1b9 
## **Description**

This PR adds the `crossAlignment` prop to the Snap UI `Box` component.
It generates a `align-items` property.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30400?quickstart=1)

## **Related issues**

Fixes: #30368 

## **Manual testing steps**

## **Screenshots/Recordings**

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@GuillaumeRx @FrederikBolding
fix default value for crossDirection
0cbd7a1
@FrederikBolding
Copy link
Member Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot metamaskbot dismissed stale reviews from GuillaumeRx and Mrtenz via 3a5148c February 19, 2025 14:27
Mrtenz
Mrtenz approved these changes Feb 19, 2025
View reviewed changes
lavamoat/browserify/beta/policy.json
@@ -2010,6 +2010,41 @@
"@metamask/snaps-utils>validate-npm-package-name": true
}
},
"@metamask/multichain-transactions-controller>@metamask/snaps-utils": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update @metamask/snaps-utils in MetaMask/core so we can dedupe this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely

@metamaskbot
Copy link
Collaborator

Builds ready [3a5148c]
Page Load Metrics (1744 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint41521661675328158
domContentLoaded15062090172614469
load15352114174414469
domInteractive21118412713
backgroundConnect117322147
firstReactRender1473312211
getState46116199
initialActions01000
loadScripts10831558124312861
setupStore762262211
uiStartup17372419201817383
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 69.83 KiB (1.13%)
  • ui: 209 Bytes (0.00%)
  • common: 63.22 KiB (0.68%)

@FrederikBolding FrederikBolding added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit 2abb96a Feb 19, 2025
79 checks passed
@FrederikBolding FrederikBolding deleted the fb/snaps-bump-v90 branch February 19, 2025 16:03
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

@GuillaumeRx GuillaumeRx GuillaumeRx approved these changes

Assignees
No one assigned
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-snaps-platform Snaps Platform team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add crossAlignment to Box
5 participants
@FrederikBolding @metamaskbot @Mrtenz @GuillaumeRx @hmalik88